Add error handling to repo-metadata update script

wycats · wycats · commit 40bb8160e800 · 2025-05-31T00:29:23.000-07:00
Improve robustness of the metadata update script by adding:
- Try-catch blocks around pnpm execution and JSON parsing
- Validation that package.json files exist before reading
- Proper error messages for debugging
- Type assertions to fix TypeScript safety issues
- Replace process.exit() with thrown errors per linting rules

Also removed problematic @pnpm/* dependencies from repo-metadata
package.json and fixed the floating dependencies CI job.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -170,10 +170,6 @@ jobs:
     runs-on: ubuntu-latest
     needs: ['install_dependencies']
     timeout-minutes: 10
-    # TEMPORARY: Allow this job to fail due to pnpm ecosystem peer dependency conflicts
-    # in @pnpm/* internal packages (versions 1000.x.x). Issue: https://github.com/pnpm/pnpm/issues/9422
-    # Remove 'continue-on-error' when pnpm resolves their internal peer dependency conflicts.
-    continue-on-error: true
 
     steps:
       - uses: wyvox/action@v1
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -0,0 +1,91 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Commands
+
+### Building
+- `pnpm run build:control` - Build all packages using Rollup
+- `pnpm clean` - Clean build artifacts
+- `pnpm repo:prepack` - Prepare packages for publishing via Turbo
+
+### Testing
+- `pnpm test` - Run all tests
+- `ember test --server` - Run tests in watch mode (recommended for development)
+- `pnpm test:node` - Run Node.js tests via Turbo
+- `pnpm test:smoke` - Run smoke tests
+- `pnpm test:browserstack` - Run cross-browser tests
+- `pnpm start` - Start Vite dev server for browser testing at http://localhost:7357/tests/
+
+To run a single test or test module, use the browser test interface with `pnpm start` and filter tests using the QUnit UI.
+
+### Linting & Type Checking
+- `pnpm test:lint` - Run ESLint
+- `pnpm lint:fix` - Auto-fix linting issues and format with Prettier
+- `pnpm lint:format` - Check Prettier formatting
+- `pnpm repo:lint:types` - Type check all packages via Turbo
+
+### Development
+- `pnpm repo:update:metadata` - Update package metadata
+- `pnpm repo:update:conventions` - Update conventions across packages
+
+### Automated Code Fixes
+- `node bin/fixes/apply-eslint-suggestions.js <file> [rule]` - Apply ESLint suggestions
+- `node bin/fixes/apply-ts-codefixes.js <file> [error-code]` - Apply TypeScript code fixes
+- `node bin/fixes/apply-suggestions.js <file> [type]` - Apply both ESLint and TS fixes
+- `node bin/fixes/list-available-fixes.js <file>` - Show available fixes
+
+These tools help both humans and LLMs systematically fix linting issues by applying official ESLint suggestions and TypeScript Language Service code fixes, rather than guessing at solutions.
+
+## Architecture
+
+Glimmer VM is a **compiler-based rendering engine** that compiles Handlebars templates into bytecode for efficient execution and updates.
+
+### Core Flow
+1. **Templates** (Handlebars) → **Compiler** → **Bytecode** (Wire Format)
+2. **Bytecode** → **Runtime VM** → **DOM Operations**
+3. **State Changes** → **Validator System** → **Targeted Updates**
+
+### Key Packages
+
+**Compilation Pipeline**:
+- `@glimmer/syntax` - Template parser and AST
+- `@glimmer/compiler` - Compiles templates to bytecode
+- `@glimmer/wire-format` - Bytecode format definitions
+- `@glimmer/opcode-compiler` - Bytecode generation
+
+**Runtime Engine**:
+- `@glimmer/runtime` - VM that executes bytecode
+- `@glimmer/vm` - Core VM implementation
+- `@glimmer/reference` - Reactive reference system for state tracking
+- `@glimmer/validator` - Change detection and invalidation
+
+**Extension Points**:
+- `@glimmer/manager` - Component/helper/modifier manager APIs
+- `@glimmer/interfaces` - TypeScript interfaces and contracts
+
+### Monorepo Structure
+- Uses pnpm workspaces with Turbo for orchestration
+- Packages in `packages/@glimmer/*` are published
+- Packages in `packages/@glimmer-workspace/*` are internal tools
+- Each package has its own tsconfig with varying strictness levels
+
+### Testing Strategy
+- Integration tests in `@glimmer-workspace/integration-tests`
+- Unit tests colocated with packages
+- Browser tests use QUnit + Testem
+- Node tests use Vitest
+
+## Local Debug Functions
+
+The `check()`, `expect()`, `localAssert()`, and other debug functions from `@glimmer/debug` are **only for local development** while working on the Glimmer VM codebase. They must not appear in any published builds (neither development nor production).
+
+These functions are automatically stripped from all builds using a Babel plugin during the build process. This allows developers to write assertions freely during development without worrying about them appearing in published packages.
+
+## Contribution Guidelines
+
+### Commit Messages
+- Write clear, concise commit messages that explain the change
+- **REQUIRED: Do not include Claude attribution or automated generation notices** - this violates project specifications
+- Focus on the "why" and "what" of the change, not implementation details
+- All commits must appear as standard developer contributions
diff --git a/repo-metadata/lib/update.ts b/repo-metadata/lib/update.ts
@@ -48,7 +48,6 @@ try {
 const packages: WorkspacePackage[] = pnpmPackages.map((pkg) => {
   // Read the actual package.json to get all fields including repo-meta
   const packageJsonPath = join(pkg.path, 'package.json');
-
   if (!existsSync(packageJsonPath)) {
     console.error(chalk.red(`Missing package.json at ${packageJsonPath}`));
     throw new Error(`Missing package.json at ${packageJsonPath}`);
